Skip to content

fix: Improve Code Quality issues#880

Merged
Roopan-Microsoft merged 4 commits into
devfrom
PSL-US-33784
Apr 21, 2026
Merged

fix: Improve Code Quality issues#880
Roopan-Microsoft merged 4 commits into
devfrom
PSL-US-33784

Conversation

@AjitPadhi-Microsoft
Copy link
Copy Markdown
Contributor

@AjitPadhi-Microsoft AjitPadhi-Microsoft commented Apr 17, 2026

Purpose

  • This pull request includes various improvements and code cleanups across the backend Python scripts and the frontend React application. The main themes are improved error handling, removal of unused code and imports, variable naming consistency, and minor logic corrections.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2026

Coverage

Coverage Report •
FileStmtsMissCoverMissing
src/api/common/database
   cosmosdb_service.py107298%31, 177
   sqldb_service.py1872288%18–26, 28–29, 62–63, 65–70, 195, 294, 334
src/api/services
   chat_service.py1721293%59–60, 223–226, 230, 233, 244–245, 265–266
TOTAL130514788% 

Tests Skipped Failures Errors Time
163 0 💤 0 ❌ 0 🔥 6.588s ⏱️

The merge of origin/dev into PSL-US-33784 incorrectly resolved the
import block in App.tsx, dropping:
- closing brace and source for @fluentui/react-components
- SparkleRegular import from @fluentui/react-icons
- App.css stylesheet import
- ChatHistoryPanel component import

This caused the Docker build-and-push CI job to fail with:
  SyntaxError: Unexpected keyword 'import'. (11:0)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@Roopan-Microsoft Roopan-Microsoft merged commit a52cb11 into dev Apr 21, 2026
5 checks passed
@AjitPadhi-Microsoft AjitPadhi-Microsoft deleted the PSL-US-33784 branch April 21, 2026 06:32
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 3.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants